Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic on HTML short codes #1690

Closed
wants to merge 5 commits into from
Closed

Don't panic on HTML short codes #1690

wants to merge 5 commits into from

Conversation

ralfbiedert
Copy link

Full disclosure, this is me mostly trying to help out debugging #1689. I don't quite understand the code I patched and just followed your advice making it run Shortcode::update_range. Feel free to close this PR.

@Keats
Copy link
Collaborator

Keats commented Dec 9, 2021

I think the first step would be to add a minimal failing test. This is not the right fix though, this will render the HTML shortcodes before rendering the markdown. Thanks for having a look though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants